-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotation of written Beamfiles with Zemax July 11, 2011 #33
Comments
ok now the format in ZEMAX is good(also my pikachu stands on its feet ;) ) But wouldn't it be better to choose a format of the electirc field like
|
Hi @xy124, Regarding your comment
... I am not quite sure what you mean. I am already changed the statement inside the double for loop to On a different note, if you don't mind, I would like to add you to the contributors page. Please let me know if it is fine with you. I will look forward to more pull requests from you in future :-). Thank you and have a good weekend. |
I completely agree in waiting for @Caterineh to decide. As I'm using zbfWrite and -Read for my current work anyway I just need to know which conversations need to be done in my python scripts. Pikachu is flipped horizontal if I directly draw it with You're welcome to add me to contributors page :) |
Hey guys, The reason I had things the way they were was to demonstrate the difference in coordinate systems between standard image formats and zemax. I would leave them the way they are. |
Well but normally it's much harder for people to recognize that the beamfile has wrong orientation than it is with Pikachu - the beamfiles I use have almost rotational symmetry . In my opinion one should either document this pretty well or make it more intuitive. |
Hi @xy124 , @CatherineH reading above, it seems to me that, may be, we should put a note (rather a "warning") about the difference in coordinate systems in the docstring, rather than changing the functions themselves. @xy124, let me know what you think. |
Hi @xy124 and @CatherineH, I just updated the master with several more functions (totally around 30). See the news and updates page for details. I have also added "xy124" to the contributors page. Thanks for pointing out the bug in the example. I have updated the example file. Please let me know if the example works as expected. Please note that I have not added any "warning message" yet. I will wait for your inputs on that (and then close this issue). Thank you all very much. |
if I execute the example beamFileWrite.py the Beamfile is rotated wrongly.
That is probably because zemax sets the origin(0,0) to the left bottom corner and not to the left top as it's done for pixel coordinates normally. Furthermore I suggest to change
into
in beamFileWrite.py
The text was updated successfully, but these errors were encountered: