Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test for nested imports #17

Merged
merged 1 commit into from
Mar 5, 2015
Merged

Added a test for nested imports #17

merged 1 commit into from
Mar 5, 2015

Conversation

kevin-smets
Copy link

Just wanted to add a test for this as I run sass graph over an extensive amount of imports.

@kevin-smets kevin-smets mentioned this pull request Mar 3, 2015
@kevin-smets kevin-smets closed this Mar 3, 2015
@kevin-smets kevin-smets deleted the feature/nested-test branch March 3, 2015 22:56
@kevin-smets kevin-smets restored the feature/nested-test branch March 3, 2015 22:57
@kevin-smets kevin-smets reopened this Mar 3, 2015
@@ -0,0 +1,4 @@
test:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Makefile, in favour of npm scripts

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simply update the path in the package.json

   "scripts": {
     "test": "./node_modules/.bin/mocha./test/test.js"
   },

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the makefile, didn't think of portability.

I changed the scripts entry to:

"scripts": {
"test": "mocha ./test/test*.js"
}

test.parse-imports.js didn't run when running npm test without the * in the test declaration.

@xzyfer
Copy link
Owner

xzyfer commented Mar 5, 2015

Thanks for this @kevin-smets.

Please remove the Makefile, it's not portable and we <3 Windows. Npm scripts are the preferred way to do this, and much more portable.

@@ -10,7 +10,7 @@
"bin": "./bin"
},
"scripts": {
"test": "mocha ./test/test.js"
"test": "mocha ./test/test*.js"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the * a typo?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind I see what's going on

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, currently npm test only runs test.js. Now running npm test will run both test.js and test.parse-imports.js

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@xzyfer
Copy link
Owner

xzyfer commented Mar 5, 2015

Could you please squash the commits into one? Then it's good to go!

Squashed commits:
[7f41677] Fixed the PRQ comments
[db9e043] Test description typo: j.scss should've been g.scss
[34de530] Added a test for nested imports
@kevin-smets
Copy link
Author

Squashed them 👍

@xzyfer
Copy link
Owner

xzyfer commented Mar 5, 2015

Great work @kevin-smets

xzyfer added a commit that referenced this pull request Mar 5, 2015
@xzyfer xzyfer merged commit dd2bf4f into xzyfer:master Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants