Support for custom imports + tests for this scenario #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var errMsg = "File to import not found or unreadable: " + sassPath; | ||
| throw errMsg; | ||
|
|
||
| var warnMsg = 'File to import not found or unreadable: assuming "' + scssPath + |
There was a problem hiding this comment.
For the moment just make this a comment and return false.
I'll add a proper logging interface later.
|
Once you're done please squash your commits and I'll release this tomorrow as 1.1.0 :) |
|
Done and done :). |
|
Is this good to merge? |
|
Hi @kevin-smets can you please rebase this of the current master? |
|
Done and done @xzyfer |
xzyfer
added a commit
that referenced
this pull request
Mar 22, 2015
…-compass-imports Add support for custom imports
|
Thanks @kevin-smets! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom imports will be ignored. the train of thought is as follows:
File not found? -> assuming it's a custom import -> this entry will not be added to the graph.