Issue/#29/optimize console output #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-brehm
approved these changes
Jun 3, 2024
maosi100
force-pushed
the
issue/#29/optimize_console_output
branch
from
1abc2ab
to
6071458
Compare
y-brehm
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Overall, I noticed that the `logging_configuration.py' file is not consistent with the rest of the codebase (usually we put different classes and functions in separate files). Consider moving logging to its own subdirectory and splitting it into different files.
|
Also this seems to be a duplicate of #42. If this was a mistake you can simply revert your changes here and apply requested changes on the quickfix branch. |
implementation of progress in processor
This reverts commit 76ec379.
maosi100
force-pushed
the
issue/#29/optimize_console_output
branch
from
a6de29e
to
29806db
Compare
y-brehm
reviewed
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more descriptive information to output while reading and processing files.