Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map code clean #21

Merged
merged 1 commit into from
Sep 1, 2023
Merged

map code clean #21

merged 1 commit into from
Sep 1, 2023

Conversation

forehalo
Copy link
Collaborator

@forehalo forehalo commented Sep 1, 2023

#20

@forehalo forehalo temporarily deployed to development September 1, 2023 03:39 — with GitHub Actions Inactive
@forehalo forehalo mentioned this pull request Sep 1, 2023
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Patch coverage: 48.57% and project coverage change: -0.01% ⚠️

Comparison is base (4312e2d) 77.63% compared to head (ca91e90) 77.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   77.63%   77.62%   -0.01%     
==========================================
  Files          42       42              
  Lines        6643     6624      -19     
==========================================
- Hits         5157     5142      -15     
+ Misses       1486     1482       -4     
Flag Coverage Δ
node-binding-test 22.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
y-octo/src/doc/document.rs 64.16% <ø> (ø)
y-octo/src/doc/types/list/search_marker.rs 83.73% <0.00%> (-1.22%) ⬇️
y-octo/src/doc/types/mod.rs 58.48% <0.00%> (ø)
y-octo/src/doc/types/map.rs 63.93% <50.00%> (+1.10%) ⬆️
y-octo/src/doc/store.rs 85.91% <63.63%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo changed the title refactory type impls map code clean Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Benchmark for Linux

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 438.0±20.13µs 457.8±20.39µs +4.52%
codec/jwst decode var_uint (32 bit) 349.5±13.58µs 370.2±18.92µs +5.92%
codec/jwst decode var_uint (64 bit) 369.8±21.74µs 379.9±17.93µs +2.73%
codec/jwst encode var_int (32 bit) 541.6±29.03µs 541.7±23.99µs +0.02%
codec/jwst encode var_uint (32 bit) 316.4±13.94µs 328.7±13.26µs +3.89%
codec/jwst encode var_uint (64 bit) 323.9±17.82µs 331.2±14.31µs +2.25%
codec/lib0 decode var_int (64 bit) 325.2±13.76µs 342.9±10.32µs +5.44%
codec/lib0 decode var_uint (32 bit) 288.0±12.67µs 298.2±12.56µs +3.54%
codec/lib0 decode var_uint (64 bit) 292.4±12.25µs 295.0±10.49µs +0.89%
codec/lib0 encode var_int (64 bit) 474.8±18.08µs 498.9±26.79µs +5.08%
codec/lib0 encode var_uint (32 bit) 330.6±17.55µs 328.5±12.12µs -0.64%
codec/lib0 encode var_uint (64 bit) 319.1±13.71µs 333.2±10.15µs +4.42%
ops/array/jwst/insert 402.4±14.43µs 422.5±15.91µs +5.00%
ops/array/jwst/insert range 566.0±18.87µs 575.8±17.84µs +1.73%
ops/array/jwst/remove 269.5±9.90µs 278.6±9.53µs +3.38%
ops/array/yrs/insert 103.7±5.77µs 101.1±3.33µs -2.51%
ops/array/yrs/insert range 125.4±5.37µs 130.4±3.76µs +3.99%
ops/array/yrs/remove 113.5±4.68µs 119.1±5.12µs +4.93%
ops/text/jwst/insert 196.8±4.92µs 180.1±6.36µs -8.49%
ops/text/jwst/remove 4.0±0.40µs 3.8±0.15µs -5.00%
ops/text/yrs/insert 48.3±1.53µs 48.9±2.64µs +1.24%
ops/text/yrs/remove 2.7±0.09µs 2.7±0.12µs -0.00%
update/parse with jwst/basic.bin 87.8±2.86µs 89.6±3.19µs +2.05%
update/parse with jwst/database.bin 70.5±2.64µs 71.6±2.36µs +1.56%
update/parse with jwst/large.bin 6.1±0.20ms 6.1±0.16ms -0.00%
update/parse with jwst/with-subdoc.bin 8.0±0.29µs 8.0±0.22µs -0.00%
update/parse with yrs/basic.bin 54.9±1.66µs 55.9±1.93µs +1.82%
update/parse with yrs/database.bin 43.3±1.56µs 46.2±1.53µs +6.70%
update/parse with yrs/large.bin 3.8±0.11ms 3.9±0.15ms +2.63%
update/parse with yrs/with-subdoc.bin 6.8±0.28µs 7.7±0.33µs +13.24%

Benchmark for Windows

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 471.1±8.23µs 479.2±20.65µs +1.72%
codec/jwst decode var_uint (32 bit) 434.8±7.24µs 435.9±17.52µs +0.25%
codec/jwst decode var_uint (64 bit) 324.5±4.48µs 324.9±4.53µs +0.12%
codec/jwst encode var_int (32 bit) 500.8±10.53µs 501.1±12.77µs +0.06%
codec/jwst encode var_uint (32 bit) 303.1±5.50µs 302.0±4.58µs -0.36%
codec/jwst encode var_uint (64 bit) 301.3±4.82µs 301.6±4.39µs +0.10%
codec/lib0 decode var_int (64 bit) 438.6±11.55µs 436.5±13.36µs -0.48%
codec/lib0 decode var_uint (32 bit) 361.5±16.52µs 355.8±4.73µs -1.58%
codec/lib0 decode var_uint (64 bit) 392.0±9.27µs 398.0±20.80µs +1.53%
codec/lib0 encode var_int (64 bit) 599.7±14.54µs 598.9±8.98µs -0.13%
codec/lib0 encode var_uint (32 bit) 405.9±11.41µs 403.4±8.15µs -0.62%
codec/lib0 encode var_uint (64 bit) 421.1±27.19µs 415.6±5.80µs -1.31%
ops/array/jwst/insert 414.2±9.90µs 409.4±6.87µs -1.16%
ops/array/jwst/insert range 541.8±9.76µs 539.4±7.42µs -0.44%
ops/array/jwst/remove 263.2±2.56µs 261.4±3.31µs -0.68%
ops/array/yrs/insert 110.4±2.79µs 109.4±2.12µs -0.91%
ops/array/yrs/insert range 150.7±2.75µs 153.2±4.76µs +1.66%
ops/array/yrs/remove 160.6±2.70µs 157.4±2.31µs -1.99%
ops/text/jwst/insert 184.6±2.63µs 182.3±2.22µs -1.25%
ops/text/jwst/remove 4.7±0.14µs 4.6±0.11µs -2.13%
ops/text/yrs/insert 48.3±1.38µs 47.6±0.60µs -1.45%
ops/text/yrs/remove 4.7±0.05µs 4.6±0.06µs -2.13%
update/parse with jwst/basic.bin 98.6±1.66µs 102.2±2.43µs +3.65%
update/parse with jwst/database.bin 76.7±1.99µs 80.4±0.93µs +4.82%
update/parse with jwst/large.bin 5.2±0.29ms 4.9±0.21ms -5.77%
update/parse with jwst/with-subdoc.bin 14.9±0.19µs 15.6±0.20µs +4.70%
update/parse with yrs/basic.bin 66.3±0.73µs 68.0±3.97µs +2.56%
update/parse with yrs/database.bin 53.3±1.21µs 51.3±1.12µs -3.75%
update/parse with yrs/large.bin 3.2±0.11ms 3.1±0.12ms -3.12%
update/parse with yrs/with-subdoc.bin 12.7±0.19µs 11.6±0.29µs -8.66%

@darkskygit darkskygit merged commit 0710cda into main Sep 1, 2023
14 checks passed
@darkskygit darkskygit deleted the refactor/types branch September 1, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants