-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libyrs.dylib built for osx arm #81
Conversation
96f2e8f
to
2521c71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, a separate package would be better.
d338e1b
to
0d53d6a
Compare
Btw: For testing I would just reference this project from the unit tests (temporarily) and then run the tests. |
Perhaps this is the reason why it is called "PackagePath" ;)...So I guess we have to publish it. But you have to explain me the other changes in the yml file before I can merge it. |
Regarding the yml file: Here you can find a comment that directs to the other repository that contains a workflow file that was used as inspiration:
Going to the other repository, you can find how it builds for both Mac x64 and arm64 I basically copied over the yaml config to my PR and adjusted the Content's Include and PackagePath accordingly to the new directories.
I am not entirely sure where the ydotnet/.github/workflows/build-binaries.yml Lines 74 to 84 in e1e2cd7
Not easy to test this locally, since nektos/act doesn't have Docker images for MacOS |
Ah, I see. aarch is just an arm variation. The point is: You cannot build for arm yet because there are not arm github runners yet. Therefore we have to build it locally and this is the reason why I cannot do it myself (because I do not have a mac). So for now, we should:
When ARM runners are available we can make another PR. |
@SebastianStehle from what I read online rust is capable to build for ARM using Intel, so it should technically be possible. If you want, we can test it, otherwise I can follow your approach! Also, Linux contains all architectures in the same project, why separate into Intel and ARM only for Mac? Wouldn't it make sense to follow the same pattern? The file is not that big, roughly 1.5 MB |
That would be great. Can you confirm that? Just run the build in your fork and download the artifacts. If it works: Great :) I agree with your argument about Mac and Linux project. I have forgotten that. Lets do one project again |
@SebastianStehle it works! Just tried on my project and it worked well. I built using github actions, downloaded the artifact and used it on my local yjs project. I also reverted the other changes and kept a single Mac project |
Add libyrs.dylib for OSX ARM