A infinite loop occured if the munin-node not allowed to connect from fluentd host

[cynipe]

Given the running munin-node that is not allowed to connect from fluentd host
When I start fluentd
Then fluentd never comes up properly
And fluent-plugin-munin starts the infinite loop to connect munin-node

It's better to have connectin_retry_count, or just start up fluentd then write a log that munin-node is not configured property.

[y-ken]

Thank you for reporting problem. It should be fixed.
I'm thinking the way to fix it.

[cynipe]

@y-ken thank you for quick response!!
And one more, actually fetch method has same issue. If the munin-node's configuration changed sometime after the first check (for working properly), fluent-plugin-munin retries to connect again and again. This also should be log that out or something.

Thanks.

P.S
BTW, is it OK to use Japanese instead of English on this project such as issue or commit comment?

[y-ken]

Now, fluent-plugin-munin has get bugs fixed.
Would you please confirm which acts as you had expected?

code diff

282fb66...ee8d1b2

new hehavior

execute fluentd but munin stopped. logging outputs below.

2013-07-13 16:36:00 +0900 [info]: adding source type="munin"
2013-07-13 16:36:00 +0900 [warn]: munin: connect failed  error_class=Munin::ConnectionError error="Connection refused - connect(2)" retry_interval=30

on starting munin...

2013-07-13 16:36:30 +0900 [info]: munin: munin-node ready  hostname="fluentd.example.com" service_list=["cpu", "df", "df_inode", "entropy", "forks", "fw_packets", "if_err_eth0", "if_eth0", "interrupts", "irqstats", "load", "memory", "netstat", "ntp_kernel_err", "ntp_kernel_pll_freq", "ntp_kernel_pll_off", "ntp_offset", "ntp_states", "open_files", "open_inodes", "proc_pri", "processes", "sendmail_mailqueue", "sendmail_mailstats", "sendmail_mailtraffic", "swap", "threads", "uptime", "users", "vmstat"]
2013-07-13 16:36:30 +0900 [info]: munin: activating service  service="cpu"
2013-07-13 16:36:30 +0900 debug.rewrite.munin.cpu: {"hostname":"fluentd.example.com","service":"cpu","user":6528636,"nice":28785,"system":5998305,"idle":2335182456,"iowait":1627270,"irq":144,"softirq":306041,"steal":0,"guest":0}

on stopping munin...

2013-07-13 16:36:40 +0900 [warn]: munin: fetch failed  error_class=Munin::ConnectionError error="Connection refused - connect(2)"

on starting munin again...

2013-07-13 16:36:50 +0900 debug.rewrite.munin.cpu: {"hostname":"fluentd.example.com","service":"cpu","user":6528688,"nice":28785,"system":5998338,"idle":2335184372,"iowait":1627273,"irq":144,"softirq":306042,"steal":0,"guest":0}

[y-ken]

BTW, is it OK to use Japanese instead of English on this project such as issue or commit comment?

It's OK to use Japanese. Also, you can ask me at the twitter@yoshi_ken with japanese.
It is better to use english at GitHub, but it does not mean to restrict japanese.

[cynipe]

Thank you for the quick action really appreciated!!
The new behavior is exactly what I want.
Thank you so much.

It's OK to use Japanese. Also, you can ask me at the twitter@yoshi_ken with japanese.
It is better to use english at GitHub, but it does not mean to restrict japanese.

Thanks. I will, when I feel difficulties to explain something.

Again, thank you so much!!

[y-ken]

I'm pleased to hear "The new behavior is exactly what I want.".
And now, I have released v0.3.2 at RubyGems.
http://rubygems.org/gems/fluent-plugin-munin

Let me know if you need anything.
Thanks. 👍