-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
funcResult.GetType() doesn't guard against GetType being undefined. #26
Comments
Mmmh, yeah, must have skipped that one. I fixed it on the dev branch, but if you have an example of ink file that runs into this error, I could use it to confirm it's ok now. |
Here's the code I mentioned. It's currently using an unminified version of the latest iife (so I can get line numbers out of the tracebacks), but switching between them should be fine. EDIT: I should have included testing.ink as well. It's some pretty abusive code, for its size. Various things you can uncomment to see how they react. |
Great, thank you. I'll have a go with it. |
TBH I don't have time to look at the testing.ink file, but running your html file with the dev version of ink produces the same output as inky and no errors, so it should be ok. But feel free to open another issue if you notice a wrong behavior with diverts etc :-) |
I'm experimenting with external functions, in particular just echoing back input, which has all kinds of confusing behavior currently. (For example, you can get a Path by passing in a divert, but I can't figure out how to send it back. For another example, returning strings is weirdly finicky.)
Many of the issues seem to come from funcResult.GetType(), currently on line 904 of Story.js, throwing an error because funcResult.GetType is not a function. This prevents the warning from being printed, and halts execution.
The text was updated successfully, but these errors were encountered: