Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inkjs-compiler: fix non-ascii identifiers #1008

Merged
merged 1 commit into from
May 6, 2023
Merged

inkjs-compiler: fix non-ascii identifiers #1008

merged 1 commit into from
May 6, 2023

Conversation

technix
Copy link
Contributor

@technix technix commented May 6, 2023

Checklist

  • The new code additions passed the tests (npm test).
  • The linter ran and found no issues (npm run-script lint).

Description

The CharacterRange.ToCharacterSet method returns only the first character defined by CharacterRange. Therefore, InkParser.ExtendIdentifierCharacterRanges extends identifierCharSet only with the first character of each character set.

This pull request fixes the ToCharacterSet method behavior, returning all characters from CharacterRange.

@smwhr smwhr self-requested a review May 6, 2023 20:16
smwhr
smwhr approved these changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@smwhr smwhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Thanks !

@smwhr smwhr merged commit 55c1286 into y-lohse:master May 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smwhr smwhr smwhr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@technix @smwhr