fix: correctly handle empty INCLUDEs #1030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
).npm run-script lint
).Description
This PR fixes a bug in the compiler with empty INCLUDEs.
Example:
If you compile it with the inkjs.Compiler and a correctly set-up JsonFileHandler, the story fails at run-time with
Unresolved variable: foo
.If
a.ink
is not empty (a single space character is enough), everything works as expected.This bug is caused by a falsy value ("") not taking the correct branch in an if statement
if (includedString)
. This PR fixes that if with a stricter check:if (includedString != null)
.