Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scale will go from 0 - 120 #1

Closed
ChrisKatsaras opened this issue Jul 10, 2017 · 3 comments
Closed

[BUG] Scale will go from 0 - 120 #1

ChrisKatsaras opened this issue Jul 10, 2017 · 3 comments

Comments

@ChrisKatsaras
Copy link

Occasionally, the calculations made by this plugin will cause the final result to 100.1 instead of 100. This causes the chart to have another Y axis point. See example image below for reference.
image

As you can see, the third column is just slightly over 100 (adding up to 100.1) which creates this issue.

@ChrisKatsaras
Copy link
Author

I think I found the issue causing this:
image
Specifies that the xAxis ticks go from 0 - 100. If I'm correct, this means vertically stacked charts may run into some minor issues (just like it did).

Quick fix?
Simply change xAxis to be yAxis

Long-term solution?
Implement chartType option so that a user may differentiate between vertical and horizontal charts

@ChrisKatsaras ChrisKatsaras reopened this Jul 10, 2017
y-takey added a commit that referenced this issue Jul 11, 2017
support for chart type is (vertical) bar
@y-takey
Copy link
Owner

y-takey commented Jul 11, 2017

Hi @ChrisKatsaras, sorry for the delay.

I had not consider about vertical bar chart. so, your advice is saved me, thank you very much! I just have fixed this issue, and published to npm registry.
could you update your plugin and test it?

@ChrisKatsaras
Copy link
Author

Tested and looks good to me! Nice work, @y-takey 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants