use weekday fn from days.js to respect locale weekday reordering #46
Conversation
… MO-SO instead of SO-SA)
|
The tests are green on my box. |
src/utils/LocaleUtil.ts
Outdated
|
|
||
| dayjs.extend(localeData); | ||
| dayjs.extend(localizedFormat); | ||
| dayjs.extend(weekday) |
There was a problem hiding this comment.
| dayjs.extend(weekday) | |
| dayjs.extend(weekday); |
it's lint error, missing semicolon
There was a problem hiding this comment.
oh thank you very much. I'll fix it asap!
|
I had to bump the dayjs dependency to get the weekday functionality. The current version in the package is 1.8.12. Weekday came one release later, in 1.8.13. I updated to the latest version: 1.8.21. However, I can change that if you prefer. |
|
hmm I can't run yarn install locally. I get an error during gyp compilation. @y0c could you please update the yarn lockfile? |
|
@flo-l I update yarn lockfile to dev branch. |
…picker into respect-locale-weekdays
|
thank you! I'm afraid I can't build the current master on my machine. I get compile errors during yarn install. I'm on Fedora Linux with Node 12.15. I can get the build to pass if I bump node-sass from 4.11.0 to 4.12.0. |
Well I'm an idiot and didn't pull from your repo, but from my fork. It works now. I changed the type of Locale from any to string | ILocale. If that is not what you intended I'll revert this change! |
|
Well done. Thank you. |
Thank you too for your lib and the merge :) |
|
One last request: Could you please do a release so I can use upstream in my project? |
|
@flo-l update version 1.0.3 |
eg. MO-SO instead of SO-SA