Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input size limits #34

Closed
y10k opened this issue Dec 9, 2019 · 1 comment
Closed

Input size limits #34

y10k opened this issue Dec 9, 2019 · 1 comment
Labels
enhancement

Comments

@y10k
Copy link
Owner

y10k commented Dec 9, 2019

  1. Line length limit
  2. Literal size limit
  3. IMAP Command total size limit

1 needs to Riser::Stream update.
2 and 3 are recommended to be larger than DRb's load_limit.
@y10k
Copy link
Owner Author

y10k commented Dec 13, 2019

Riser is updated by #6

y10k added a commit that referenced this issue Feb 28, 2020
@y10k
rims error: add line too long error (#34)
961733c 
Github Issue: #34
y10k added a commit that referenced this issue Feb 28, 2020
@y10k
request reader: fix test (#34)
9649cb8 
Github Issue: #34

Add stringio requirement to run this test case alone.
y10k added a commit that referenced this issue Feb 28, 2020
@y10k
request reader: refactoring test (#34)
d32e456 
Github Issue: #34

Make some tests data driven.
y10k added a commit that referenced this issue Feb 28, 2020
@y10k
request reader: add gets method with line length limit (#34)
7574e0b 
Github Issue: #34
y10k added a commit that referenced this issue Feb 28, 2020
@y10k
protocol decoder: add request reader factory method (#34)
bf1c6ad 
Github Issue: #34

Add the factory method to initial decoder to encapsulate the
initialization parameters of request reader those will be added after
this.
y10k added a commit that referenced this issue Feb 28, 2020
@y10k
protocol decoder: line too long error handling (#34)
b251022 
Github Issue: #34

Line too long error terminates server-client connection because the
server does not know how much data remains beyond its line length
limit.
y10k added a commit that referenced this issue Feb 28, 2020
@y10k
service: add protocol line length limit configuration parameter (#34)
762bec1 
Github Issue: #34
y10k added a commit that referenced this issue Feb 28, 2020
@y10k
server command: add line length limit option (#34)
af14a3c 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: test not to read end of too long line (#34)
0501ffa 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
protocol decoder: refactoring test (#34)
31fb910 
Github Issue: #34

Test names for line too long error handling have been adapted to
naming rules.
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
protocol decoder: test that stream closes after line too long error (#34
bf848fb 
)

Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
protocol decoder: use default configuration parameter at line length …
ec1212d 
…limit (#34)

Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
service: logging protocol line length limit configuration parameter (#34
20d93be 
)

Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: add state-less atom scan method (#34)
586976b 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: add state-less parse method (#34)
480ee65 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: no use state-full `parse' method. (#34)
410ba8f 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: delete state-full `parse' method. (#34)
7aa5ed9 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: no use state-full `scan_line' method (#34)
65546d0 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: delete state-full `scan_line' method (#34)
015f7f5 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: `read_line' method to be private (#34)
67b2eb2 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: add command tag attribute (#34)
f93c336 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
protocol decoder: add command tag to syntax error handling (#34)
5ecf772 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
rims error: add read size error (#34)
f72d273 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
rims error: add literal size too large error (#34)
cd4e274 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
request reader: add literal size too large error (#34)
580222d 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
protocol decoder: literal size too large error handling (#34)
efdbb45 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
service: add protocol literal size limit configuration parameter (#34)
f9a9552 
Github Issue: #34
y10k added a commit that referenced this issue Mar 19, 2020
@y10k
server command: add literal size limit option (#34)
561e82c 
Github Issue: #34
y10k added a commit that referenced this issue Jul 7, 2020
@y10k
rims error: add recoverable read size error (#34)
95c9a20 
Github Issue: #34
y10k added a commit that referenced this issue Jul 7, 2020
@y10k
rims error: add command size too large error (#34)
0ddfb32 
Github Issue: #34
y10k added a commit that referenced this issue Jul 7, 2020
@y10k
request reader: add command size too large error (#34)
c600281 
Github Issue: #34
y10k added a commit that referenced this issue Jul 7, 2020
@y10k
protocol decoder: command size too large error handling (#34)
81134a5 
Github Issue: #34
y10k added a commit that referenced this issue Jul 7, 2020
@y10k
service: add protocol command size limit configuration parameter (#34)
f78e0c8 
Github Issue: #34
@y10k y10k closed this as completed in 702894c Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@y10k