Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updated boost libraries #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ThomasNolte
Copy link

@ThomasNolte ThomasNolte commented Dec 7, 2018

With all my compiling attempts I was able to finally get an executable to build. However it doesn't launch the game it just closes instantly. Since I don't have much to show on that front I figured I at least include the updated boost 1.6.2 libraries I used to compile things locally.

Since the project still uses boost having a working version around could be useful an tell phasing out boost entirely as been completed. They may also be used in the future for compiling locally similar to how the original project shipped them with the source code for would be contributors.

There are a lot of files since this is the full 1.6.2 boost library and can probably have many of the files removed without worry (I'll look into at that next). With the libraries being in the repository it would also eliminate the need to to install them for the TraveCI build (I think).

@y2s82
Copy link
Owner

y2s82 commented Dec 9, 2018

I am less than convinced on the idea of reintroducing boost library back into our repository.
Can we instead make a good documentation and/or installation scripts for Windows developers to follow?
Your journey to get this to work is worthy of being recorded, I must say :)
(Here, I assume casual gamers only care about release binaries, which we hope to solve by using AppAvyer or Travis CI that can generate necessary dll's)

Also, the latest Boost is known to do exactly what you are experiencing: @rdittrich97 tried it, too, in the linux environment and ended up with a binary that quit silently. I suspect the minor version change from 1.5 to 1.6 introduced change in some member function here and data structure there that ultimately causes some weird error. So, until we can minimize the reliance enough to pinpoint the cause, let's not update the boost to the latest.

@y2s82 y2s82 added this to In progress in In the name of Portability via automation Dec 9, 2018
@y2s82 y2s82 removed this from In progress in In the name of Portability Dec 9, 2018
@y2s82
Copy link
Owner

y2s82 commented Dec 9, 2018

If you are interested in finding all boost libraries included in the current code base, try the following command in the bash environment (i.e. git bash):

git grep '#include [<]boost' | sed -n 's/^.*<\([^>]*\)>.*$/\1/p' | sort | uniq

and if you want to output it to a file for later use,

git grep '#include [<]boost' | sed -n 's/^.*<\([^>]*\)>.*$/\1/p' | sort | uniq > boostfile.txt

This will list all unique instances of #include statements that refers to boost, thereby giving you an idea as to which libraries are being used.

You could further use such list to perform a modular install of boost and its maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants