Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doesn't seem to save images from CSS background url #59

Closed
officialkirill opened this issue Sep 15, 2019 · 2 comments · Fixed by #78
Closed

doesn't seem to save images from CSS background url #59

officialkirill opened this issue Sep 15, 2019 · 2 comments · Fixed by #78
Labels
todo On the current to-do list for the project

Comments

@officialkirill
Copy link

Looks like monolith doesn't save images that are references by URL in CSS.

Otherwise, thanks, this tool is very useful!
@officialkirill
Copy link
Author

alright, I'm no RUST programmer but I can see that monolith only loads CSS for embedding, but it should probably parse it too, if we want all the images loaded from CSS.

@snshn
Copy link
Member

snshn commented Sep 16, 2019

Greetings @officialkirill,

Thank you for the report! I'm currently working on parsing resources linked via style attributes and stylesheets, it should be finished and merged into the master branch in a couple of weeks.

@snshn snshn added the todo On the current to-do list for the project label Sep 16, 2019
@knidarkness knidarkness mentioned this issue Oct 12, 2019
Closed
@Alch-Emi Alch-Emi mentioned this issue Dec 6, 2019
Merged
@snshn snshn closed this as completed in #78 Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo On the current to-do list for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load URLs in CSS and style attributes Alch-Emi/monolith
2 participants
@officialkirill @snshn