Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kotlin Metadata annotations #129

Open
ctadlock opened this issue Nov 22, 2022 · 2 comments
Open

Remove Kotlin Metadata annotations #129

ctadlock opened this issue Nov 22, 2022 · 2 comments
Labels
difficulty:medium Some knowledge required. enhancement New feature or request

Comments

@ctadlock
Copy link

Kotlin adds a Metadata annotationto every class which includes the class name and all function names; mostly defeating the purpose of renaming. There in an unmeta plugin, but it would be better if it was incorporated into this one so didnt have to deal with both.

@ctadlock ctadlock changed the title Remove Kotlin Metadata annotation Remove Kotlin Metadata annotations Nov 22, 2022
@yGuy
Copy link
Member

yGuy commented Nov 22, 2022

IIRC, by default yGuard already removes annotations that are not marked as runtime visible annotations. Can you please provide more information about how these annotations work (are annotated) and how they are used? Because if they don't get removed, then these should be runtime visible annotations which again would indicate that Kotlin might need them at runtime. Pointing to relevant documentation would be helpful to decide on how to proceed. Thanks

@yGuy yGuy added enhancement New feature or request needs-information There is far too little information available to proceed. labels Nov 22, 2022
@Fohlen
Copy link
Member

Fohlen commented Mar 18, 2023

There's a comprehensive blog article from the R8 team here. The Gist is that:

  • removing the annotations breaks Kotlin support
  • the annotation references superclass names (these need to be adjusted)

To correctly support Kotlin we should therefore adjust superclass references in Kotlin annotations

@Fohlen Fohlen added good first issue Good for newcomers difficulty:medium Some knowledge required. and removed needs-information There is far too little information available to proceed. labels Mar 18, 2023
@Fohlen Fohlen removed the good first issue Good for newcomers label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium Some knowledge required. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants