Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SerialPort error listner #380

Merged
merged 5 commits into from
Dec 20, 2020
Merged

Added SerialPort error listner #380

merged 5 commits into from
Dec 20, 2020

Conversation

cakemasher
Copy link
Contributor

Referes to issue #379

@yaacov
Copy link
Owner

yaacov commented Dec 20, 2020

Thanks ! waiting for test to be green 💚

@cakemasher
Space removal
da53b7f
@cakemasher
Removed spaces + changed error event
d5c35a1 
Added error event function and changed the removeAllListners function to leave the error listner alone.
@cakemasher
Removed space and semicolon
13350b2
@cakemasher
Copy link
Contributor Author

Passing the checks was the hardest part... 😅

@yaacov yaacov merged commit 9a8c529 into yaacov:master Dec 20, 2020
@yaacov
Copy link
Owner

yaacov commented Dec 20, 2020

thanks 👍

@yaacov yaacov mentioned this pull request Dec 20, 2020
Closed
@everhardt everhardt mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cakemasher @yaacov