fix(delegation): do not override null defaults

yaacovCR · Mar 27, 2020 · 3224224 · 3224224
1 parent 0b1477c
commit 3224224
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 31 deletions.
diff --git a/src/delegate/createRequest.ts b/src/delegate/createRequest.ts
@@ -174,10 +174,10 @@ function updateArgumentsWithDefaults(
     const argName = argument.name;
     const sourceArgType = argument.type;
 
-    if (argumentNodeMap[argName] == null) {
+    if (argumentNodeMap[argName] === undefined) {
       const defaultValue = argument.defaultValue;
 
-      if (defaultValue != null) {
+      if (defaultValue !== undefined) {
         updateArgument(
           argName,
           sourceArgType,

diff --git a/src/polyfills/toConfig.ts b/src/polyfills/toConfig.ts
@@ -134,7 +134,7 @@ export function toConfig(graphqlObject: any) {
       graphqlObject.subscribe != null
     ) {
       return fieldToConfig(graphqlObject);
-    } else if (graphqlObject.defaultValue != null) {
+    } else if (graphqlObject.defaultValue !== undefined) {
       return inputFieldToConfig(graphqlObject);
     }
 

diff --git a/src/wrap/transforms/AddArgumentsAsVariables.ts b/src/wrap/transforms/AddArgumentsAsVariables.ts
@@ -84,13 +84,16 @@ function addVariablesToRootField(
 
         const targetField = type.getFields()[selection.name.value];
 
-        updateArguments(
-          targetField,
-          argumentNodeMap,
-          variableDefinitionMap,
-          variableValues,
-          args,
-        );
+        // excludes __typename
+        if (targetField != null) {
+          updateArguments(
+            targetField,
+            argumentNodeMap,
+            variableDefinitionMap,
+            variableValues,
+            args,
+          );
+        }
 
         newSelectionSet.push({
           ...selection,
@@ -124,32 +127,28 @@ function addVariablesToRootField(
   };
 }
 
+const hasOwn = Object.prototype.hasOwnProperty;
+
 function updateArguments(
   targetField: GraphQLField<any, any>,
   argumentNodeMap: Record<string, ArgumentNode>,
   variableDefinitionMap: Record<string, VariableDefinitionNode>,
   variableValues: Record<string, any>,
   newArgs: Record<string, any>,
 ): void {
-  if (targetField != null) {
-    targetField.args.forEach((argument: GraphQLArgument) => {
-      const argName = argument.name;
-      const argType = argument.type;
-
-      if (newArgs[argName] != null) {
-        const newArg = newArgs[argName];
-
-        if (newArg != null) {
-          updateArgument(
-            argName,
-            argType,
-            argumentNodeMap,
-            variableDefinitionMap,
-            variableValues,
-            serializeInputValue(argType, newArg),
-          );
-        }
-      }
-    });
-  }
+  targetField.args.forEach((argument: GraphQLArgument) => {
+    const argName = argument.name;
+    const argType = argument.type;
+
+    if (hasOwn.call(newArgs, argName)) {
+      updateArgument(
+        argName,
+        argType,
+        argumentNodeMap,
+        variableDefinitionMap,
+        variableValues,
+        serializeInputValue(argType, newArgs[argName]),
+      );
+    }
+  });
 }