Improve typing and export CKEditorComponent #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chymz: please create new npm package and add release files. Thank you. |
|
Could you please publish the latest release files: https://github.com/chymz/ng2-ckeditor/releases Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly configures
@types/ckeditorand improves the typing of some of the properties in theCKEditorComponent.On top of that, I added an export of
CKEditorComponentto the mainindex.tsbarrel file. Some applications need to be able to importCKEditorComponent, my application for instance takes a reference to the component to be able to call a method explicitly.