Configurable controller and action default tags #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liaden
force-pushed
the
enable-controller-action-tags
branch
from
c6d3a74
to
55a386c
Compare
|
Thank you for pull request! But for now it looks quite application-specific. Will it be useful for an average user of this gem? Can you think of any use cases that are applicable for a lot of people? |
|
I don't mind this not being included since it might be fragile with the monkey patch of rails. I do think it is useful though for a lot of users though. I think the value comes from being able to filter other metrics from other gems pretty easily. I can see which endpoint is queueing sidekiq jobs with yabeda-sidekiq and see which endpoints are making http requests with the yabeda-http_reqests plugin I believe yabeda-sidekiq allows for similar functionality with https://github.com/yabeda-rb/yabeda-sidekiq#custom-tags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This depends on #19 to work.