Allow capture of error class when job fails #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gem captures failed jobs with the jobs_failed_total metric, but does not provide a way to add a label for the error class, which can be useful. This commit allows developers to optionally include a label with the error class on the jobs_failed_total metric.
|
Woops meant to make this on my fork! |
|
But why not here? 😄 |
|
Soon! |
Envek
reviewed
Feb 10, 2024
Comment on lines
+26
to
+33
| if (config_value = Yabeda::Sidekiq.config.label_for_error_class_on_sidekiq_jobs_failed) | ||
| label = if config_value.is_a?(Symbol) || config_value.is_a?(String) | ||
| config_value | ||
| else | ||
| DEFAULT_JOB_FAILED_ERROR_LABEL_KEY | ||
| end | ||
| sidekiq_jobs_failed_labels[label] = e.class.name | ||
| end |
There was a problem hiding this comment.
Why is that flexibility needed? Wouldn't just error tag be enough?
Suggested change
| if (config_value = Yabeda::Sidekiq.config.label_for_error_class_on_sidekiq_jobs_failed) | |
| label = if config_value.is_a?(Symbol) || config_value.is_a?(String) | |
| config_value | |
| else | |
| DEFAULT_JOB_FAILED_ERROR_LABEL_KEY | |
| end | |
| sidekiq_jobs_failed_labels[label] = e.class.name | |
| end | |
| if Yabeda::Sidekiq.config.label_for_error_class_on_sidekiq_jobs_failed | |
| sidekiq_jobs_failed_labels[:error] = e.class.name | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem captures failed jobs with the jobs_failed_total metric, but does not provide a way to add a label for the error class, which can be useful. This commit allows developers to optionally include a label with the error class on the jobs_failed_total metric.