Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work when MediumEditor is not defined globally (e.g., when module is defined, e.g., in Meteor) #41

Merged
merged 7 commits into from
May 29, 2018
Merged

Doesn't work when MediumEditor is not defined globally (e.g., when module is defined, e.g., in Meteor) #41

merged 7 commits into from
May 29, 2018

Conversation

znewsham
Copy link
Contributor

No description provided.

znewsham added 2 commits November 14, 2016 20:16
Update medium-editor-tables.js
8b19f81 
if module != undefined this doesnt work. (e.g., Meteor)
Update medium-editor-tables.js
376ca75
@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.211% when pulling 376ca75 on znewsham:master into cedc228 on yabwe:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.211% when pulling 6830556 on znewsham:master into cedc228 on yabwe:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.211% when pulling 7dd8c8c on znewsham:master into cedc228 on yabwe:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.211% when pulling ee818fc on znewsham:master into cedc228 on yabwe:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.211% when pulling 98d67c6 on znewsham:master into cedc228 on yabwe:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.211% when pulling 98d67c6 on znewsham:master into cedc228 on yabwe:master.

curtd59
curtd59 approved these changes Feb 24, 2018
View reviewed changes
Copy link

@curtd59 curtd59 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug is still outstanding, and I just spent a few hours tracking this down. The fix is correct. It's is a simple modification. And it eliminates the dreaded "MediumEditor Not Found" message. And it should be released.

@fmy
Copy link

fmy commented May 29, 2018

@j0k3r please merge this pr.

@j0k3r j0k3r merged commit 6b72b23 into yabwe:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

@curtd59 curtd59 curtd59 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@znewsham @coveralls @fmy @j0k3r @curtd59