issue-51: Resolved IE10 table insertion issue #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix Travis first. |
j0k3r
reviewed
Jun 1, 2017
src/js/grid.js
Outdated
| }, | ||
| active = this._currentCell && | ||
| cell.row <= this._currentCell.row && | ||
| cell.column <= this._currentCell.column; | ||
|
|
||
| if (active === true) { | ||
| el.classList.add('active'); | ||
| if ('classList' in document.createElement('div')) { |
There was a problem hiding this comment.
Can't you do if ('classList' in el) { instead?
There was a problem hiding this comment.
sure, will do that change.
j0k3r
reviewed
Jun 1, 2017
src/js/grid.js
Outdated
| @@ -92,15 +100,15 @@ Grid.prototype = { | |||
| var self = this, | |||
| timer; | |||
|
|
|||
| el.addEventListener('mouseenter', function () { | |||
| el.addEventListener('mouseenter', function (e) { | |||
| clearTimeout(timer); | |||
|
|
|||
| var dataset = this.dataset; | |||
There was a problem hiding this comment.
Since you don't use dataset, I think you can remove that line
vikasrj
added a commit
to durgeshahire4/medium-editor-tables
that referenced
this pull request
Jun 2, 2017
issue-51: Resolved IE10 table insertion issue (yabwe#52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@j0k3r Please find pull request for #51