Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heading and list formatting #1348

Open
steoo opened this issue Jul 13, 2017 · 0 comments
Open

Heading and list formatting #1348

steoo opened this issue Jul 13, 2017 · 0 comments

Comments

@steoo
Copy link
Contributor

steoo commented Jul 13, 2017 •
edited
Loading

Description

The html gets real messy when trying to switch from list to heading formatting

Steps to reproduce

  1. Apply ordered list formatting on one element
  2. Select first element in list and apply h1
  3. Apply again h1

Expected behavior:
Remove H1 formatting

Actual behavior:
Wraps the ol into a p and does not remove formatting

Link to an example:
Tested in demo/custom-toolbar.html

Versions

  • medium-editor: latest
  • browser: Chrome
  • OS: Mac OS Sierra

In my opinion, if the text is formatted as list and heading is applied, it should remove the list and create an heading outside the list
dmx-patrick added a commit to DMXzone/medium-editor that referenced this issue Jul 21, 2017
@dmx-patrick
by adding div to list of block containers it did not convert the divs…
aac63d4 
… created after a enter to a p tag, this is now catched.

Fix for when applying block formatting when on a list item, it will
remove list formatting first.

fixed issue yabwe#1348
@dmx-patrick dmx-patrick mentioned this issue Jul 21, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steoo