Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote problem #294

Closed
caxopog opened this issue Sep 11, 2014 · 5 comments
Closed

Blockquote problem #294

caxopog opened this issue Sep 11, 2014 · 5 comments

Comments

@caxopog
Copy link

caxopog commented Sep 11, 2014

Hello

If i type 1 paragraph of text in editor and make it blockquote using editor button, i'll be unable to make non-blockquote paragraph, because "enter" makes new line in blockquote section, not new, non-blockquote paragraph.

Is there any way to make one of this:

  1. Enter makes new paragraph not outside of blockquote block
  2. After pressing blockquote button, new paragraph is appearing under the created blockquote

Thanks.

@yacomink
Copy link
Contributor

I had the same two needs that you are describing, and I wrote a plugin to
replace the built-in blockquote tool:
https://github.com/yacomink/medium-editor-blockquote-plugin

On Thu, Sep 11, 2014 at 3:40 AM, caxopog notifications@github.com wrote:

Hello

If i type 1 paragraph of text in editor and make it blockquote using
editor button, i'll be unable to make non-blockquote paragraph, because
"enter" makes new line in blockquote section, not new, non-blockquote
paragraph.

Is there any way to make one of this:

  1. Enter makes new paragraph not outside of blockquote block
  2. After pressing blockquote button, new paragraph is appearing under the
    created blockquote

Thanks.


Reply to this email directly or view it on GitHub
#294.

@caxopog
Copy link
Author

caxopog commented Sep 22, 2014

I've got some strange error:

TypeError: Illegal constructor.
on this line
bq = new Element('blockquote');

Maybe it's cause this script uses prototype library?

@yacomink
Copy link
Contributor

oops! should be fixed now

On Mon, Sep 22, 2014 at 3:40 AM, caxopog notifications@github.com wrote:

I've got some strange error:

TypeError: Illegal constructor.
on this line
bq = new Element('blockquote');


Reply to this email directly or view it on GitHub
#294 (comment)
.

@caxopog
Copy link
Author

caxopog commented Sep 23, 2014

If i write 1 paragraph of text and trying to make it blockquote, i got this:
InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable
range.surroundContents(bq); (line 64)

And when i'm trying to remove blockquote, it gives this error:
TypeError: bq.replace is not a function
bq.replace( bq.innerHTML ); (line 36)

@nmielnik
Copy link
Member

Fixed via #1162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants