Fix #234 - Cursor rendering incorrectly in firefox #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmielnik
changed the title
nmielnik
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Firefox, when the editor element is completely empty (including when it doesn't have
<p><br /></p>), the absolutely positioned pseudo-element used for a placeholder affects where the blinking cursor appears once the editor is focused.When the pseudo-element is positioned
relativein this case, everything renders as expected. However, when positionedrelative, the placeholder renders incorrectly for other cases and renders incorrectly in other browsers.This fix ensures that only in firefox, and only when the editor element is completely empty, the placeholder is positioned
relative. As far as I can tell, this fixes the issue.