Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for paste and placeholder extensions + add/remove element events #1124

Merged
merged 7 commits into from
Jun 20, 2016
Merged

Fixes for paste and placeholder extensions + add/remove element events #1124

merged 7 commits into from
Jun 20, 2016

Conversation

nmielnik
Copy link
Member

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets Fixing issue related to discussion in #1120
License MIT

Description

  1. Expose new addElement and removeElement custom events for extensions to listen to
  2. Fix issue with paste-handler introduced by 8bd8f8f where right-click paste isn't getting the actual paste event object so it wouldn't have access to the clipboard data.
    • As part of the fix, paste-handler now needs to know when elements are added to the editor
  3. Fix issues with placeholder extension where dynamically added elements are not getting a placeholder, and dynamically removed elements aren't being cleaned up.

@nmielnik nmielnik mentioned this pull request Jun 18, 2016
Closed
@j0k3r
Copy link
Contributor

j0k3r commented Jun 20, 2016

Looks ok to me 👍

@nmielnik nmielnik merged commit 258d1df into master Jun 20, 2016
@j0k3r j0k3r deleted the paste-handler-fix branch June 20, 2016 13:51
@marcelotedeschi marcelotedeschi mentioned this pull request Apr 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmielnik @j0k3r