Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1127 | Placeholder is visible when only empty table is in Editor. #1128

Merged
merged 2 commits into from
Jun 21, 2016
Merged

#1127 | Placeholder is visible when only empty table is in Editor. #1128

merged 2 commits into from
Jun 21, 2016

Conversation

durgeshahire4
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets 1127
License MIT

@durgeshahire4 durgeshahire4 mentioned this pull request Jun 20, 2016
Closed
@j0k3r
Copy link
Contributor

j0k3r commented Jun 20, 2016

How does it work with medium-editor-tables?

@durgeshahire4
Copy link
Author

didn't get your question. Can you please elaborate?

@j0k3r
Copy link
Contributor

j0k3r commented Jun 20, 2016

Have you tried your behavior with https://github.com/yabwe/medium-editor-tables ?

@durgeshahire4
Copy link
Author

durgeshahire4 commented Jun 20, 2016 •
edited
Loading

Yes, i am using same extension

@durgeshahire4
Copy link
Author

@j0k3r Is this Bug or existing functionality?

@j0k3r
Copy link
Contributor

j0k3r commented Jun 20, 2016

Good question :)

@nmielnik
Copy link
Member

@durgeshahire4 this looks good, could you add a test to verify this? There are a bunch of very similar tests that you can use as a template here

@nmielnik nmielnik mentioned this pull request Jun 20, 2016
Closed
@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 94.921% when pulling e39438a on durgeshahire4:master into d71cf26 on yabwe:master.

@durgeshahire4
Copy link
Author

@j0k3r @nmielnik i have updated the test cases, Have a look

@j0k3r
Copy link
Contributor

j0k3r commented Jun 21, 2016

Looks ok to me 👍

@nmielnik
Copy link
Member

All the tests passed in SauceLabs: https://travis-ci.org/yabwe/medium-editor/builds/139188607

@nmielnik nmielnik merged commit 78e42b1 into yabwe:master Jun 21, 2016
@durgeshahire4
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@durgeshahire4 @j0k3r @nmielnik @coveralls