Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle new google docs font weights #1168

Merged
merged 2 commits into from
Aug 4, 2016
Merged

Conversation

nelsonpecora
Copy link
Contributor

@nelsonpecora nelsonpecora commented Aug 3, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets #1167
License MIT

Description

Added support for numbered font weights when pasting from Google Docs, as it looks like they switched to those sometime in the past month or so.

Please, don't submit /dist files with your PR!

@coveralls
Copy link

coveralls commented Aug 3, 2016

Coverage Status

Coverage remained the same at 94.986% when pulling 4810940 on nelsonpecora:google-docs into 80356a4 on yabwe:master.

@nelsonpecora
Copy link
Contributor Author

This could probably do with a test, but when I added one it started breaking unrelated tests (specifically toolbar positioning). Thoughts?

@j0k3r
Copy link
Contributor

j0k3r commented Aug 4, 2016

Well, add a new tests and we'll see how Travis is going about that

@nelsonpecora
Copy link
Contributor Author

Roger that!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.986% when pulling 9b86ec9 on nelsonpecora:google-docs into 80356a4 on yabwe:master.

@nelsonpecora
Copy link
Contributor Author

nelsonpecora commented Aug 4, 2016

Well ok then. ¯_(ツ)_/¯

@j0k3r
Copy link
Contributor

j0k3r commented Aug 4, 2016

👍

@nmielnik nmielnik merged commit bbfd7ab into yabwe:master Aug 4, 2016
@nelsonpecora nelsonpecora deleted the google-docs branch August 4, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants