Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unwrapTags option to paste extension #1177

Merged
merged 2 commits into from
Aug 20, 2016
Merged

Conversation

paradite
Copy link
Contributor

@paradite paradite commented Aug 13, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets #1141
License MIT

Description

Added unwrapTags option to paste extension, which instead of removing the tag element entirely, removes the tag element but preserves its children.

See issue #1141 for detailed description.

I added a new test case and I did some manual testing with demo/clean-paste.html.

Please, don't submit /dist files with your PR!

@coveralls
Copy link

coveralls commented Aug 13, 2016

Coverage Status

Changes Unknown when pulling 5846a97 on paradite:unwrapTags into * on yabwe:master*.

@j0k3r
Copy link
Contributor

j0k3r commented Aug 17, 2016

Looks good to me.
@nmielnik ?

@nmielnik
Copy link
Member

nmielnik commented Aug 20, 2016

This looks awesome, nice work @paradite !

  • Add a useful feature
  • Updated documentation
  • Good Comments
  • Add tests to cover all uses of the feature

You covered all the bases for a great PR! Also, thanks for update the TOC links for OPTIONS.md

I'll make a quick integration branch to make sure all the tests pass in SauceLabs, if they do they I'll just merge this in.

https://travis-ci.org/yabwe/medium-editor/builds/153796581

@nmielnik nmielnik merged commit f5d2163 into yabwe:master Aug 20, 2016
@paradite
Copy link
Contributor Author

@nmielnik sorry, I just spotted a minor issue, the example in https://github.com/yabwe/medium-editor#paste-options is not updated with this option. Maybe you can a quick fix for that?

@nmielnik
Copy link
Member

Ah, forgot about the README! Yeah, I'll add something, great catch.

@nmielnik
Copy link
Member

@paradite thanks for pointing that out, I found a few other places in the documentation that needed updating:

56acee3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants