Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed iframe div #1179

Merged
merged 1 commit into from
Aug 22, 2016
Merged

fixed iframe div #1179

merged 1 commit into from
Aug 22, 2016

Conversation

dzy321
Copy link

@dzy321 dzy321 commented Aug 17, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT

Description

//content in iframe
var doc = content.ownerDocument;
var editor = new MediumEditor(content, {
      .........
      contentWindow: doc.defaultView || doc.parentWindow,
      ownerDocument: doc
});

if convert iframe's div to editor,it will throw error.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 59e2aa6 on dzy321:master into * on yabwe:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ba4ea63 on dzy321:master into * on yabwe:master*.

@nmielnik
Copy link
Member

@dzy321 thanks for finding and fixing this bug!

Can you remove the files from the /dist folder from this PR? (See the Contribution Guide)

Also, can you remove the changes from Gruntfile.js and package.json? I'm not sure what those changes are, but I don't think we want them in the core repo.

If possible, you may want to squash all of these into a single commit as well.

Thanks again! Once you fix up this PR, we'll be happy to merge this in.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 87c7f46 on dzy321:master into * on yabwe:master*.

@dzy321
Copy link
Author

dzy321 commented Aug 22, 2016

Thanks for you suggestion , i have recommited my pr.

@nmielnik nmielnik merged commit 12f6603 into yabwe:master Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants