Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1216 from previous PR #1217 #1293

Merged
merged 6 commits into from
Feb 8, 2017
Merged

Fix #1216 from previous PR #1217 #1293

merged 6 commits into from
Feb 8, 2017

Conversation

nmielnik
Copy link
Member

@nmielnik nmielnik commented Feb 8, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets #1216
License MIT

Description

From @annayafi in #1216:

The problem was : when you call addClassToAnchors(el, buttonClass) function :

  • if el is an <a> : no problem, it adds the css class(es)
  • if el has <a> children : no problem, it adds the css class(es) to children
  • if el is a child of an <a> : the function never looks for parent and won't add the css class(es).
    This happens very easily when you select more than a node, for example you select exactly <i>hello</i>, css is never added.

This PR wraps up #1216 by fixing some spacing issues and resolving a bug in the code. Thanks again @annayafi for opening the issue and fixing it! (Sorry for the massive delay in getting your fix merged!)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a6c5c71 on integration-1216 into ** on master**.

@j0k3r j0k3r merged commit ba69260 into master Feb 8, 2017
@j0k3r j0k3r deleted the integration-1216 branch February 8, 2017 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants