Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noopener & noreferrer into targetBlank #1355

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

tgfjt
Copy link
Contributor

@tgfjt tgfjt commented Jul 27, 2017

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
New tests added? yes
Fixed tickets #1354
License MIT

Description

add rel="noopener noreferrer" into anchor, if targetBlank.

--

Please, don't submit /dist files with your PR!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ac5a6cb on tgfjt:feature/tabnabbing into ** on yabwe:master**.

Copy link
Contributor

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me 👍
Thanks for your first contrib!

@j0k3r j0k3r merged commit c619e75 into yabwe:master Jul 27, 2017
@tgfjt tgfjt deleted the feature/tabnabbing branch July 27, 2017 21:06
@tgfjt
Copy link
Contributor Author

tgfjt commented Jul 27, 2017

@j0k3r Thanks!
Would you tell me when it would be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants