Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken browser tests #1396

Merged
merged 4 commits into from
Dec 19, 2017
Merged

Fix broken browser tests #1396

merged 4 commits into from
Dec 19, 2017

Commits on Dec 19, 2017

  1. fix chrome button tests 

    to fix the broken button tests in chrome, we want to strip empty attributes
(especially styles, because the tests create style tags, inject style
content, and then remove that style content).

some browsers will remove empty attributes automatically, others (Chrome, seemingly) will not.
    @nchase
    nchase committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    0f510ab View commit details
    Browse the repository at this point in the history

  2. fix firefox line item test 

    another scenario where browser internal rules change and the generated
DOM is slightly different than what we expect.
    @nchase
    nchase committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    318606d View commit details
    Browse the repository at this point in the history

  3. use localhost instead of 127.0.0.1 for sauce tests

    @nchase
    nchase committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    358fcd9 View commit details
    Browse the repository at this point in the history

  4. use .toMatch to catch optional linebreak

    @nchase
    nchase committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    52defad View commit details
    Browse the repository at this point in the history