fix null error on pastedPlain.split #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchase
force-pushed
the
fix-undefined-in-dopaste
branch
from
08f99c1
to
005d4e7
Compare
I saw some errors where pastedPlain was undefined, so the `.split` would throw an error. I don't know if this is the best place to fix the bug, but I wanted to start a conversation around the bug nonetheless.
nchase
force-pushed
the
fix-undefined-in-dopaste
branch
from
005d4e7
to
f1386c7
Compare
|
Changes Unknown when pulling f1386c7 on fix-undefined-in-dopaste into ** on master**. |
|
Changes Unknown when pulling f1386c7 on fix-undefined-in-dopaste into ** on master**. |
nmielnik
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I saw some errors where pastedPlain was undefined, so the
.splitwould throw an error.I don't know if this is the best place to fix the bug, but I wanted to start a conversation around the bug nonetheless.