Auto link: fix bug when entering link at end of paragraph #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,7 +125,7 @@ module.exports = function (grunt) { | |||
| consolidate: true | |||
| }, | |||
| keepRunner: true, | |||
| template: require('grunt-template-jasmine-istanbul'), | |||
| //template: require('grunt-template-jasmine-istanbul'), | |||
There was a problem hiding this comment.
Oops, sorry. Didn't think I committed that - had disabled the template to make debugging the unit test page easier, re-enabled now.
|
Could you remove dist files from your PR ? Thanks |
If the user adds some spaces after what used to be an autolink, it shouldn't cause the auto-link span to be removed. Move the spaces outside of the span instead.
patrick-webs
force-pushed
the
auto-link-fixes-3
branch
from
39598c5
to
741cb77
Compare
…elements After code review it was suggested to import/export the selection with reference to all possible parent block elements (h1, h2, pre, blockquote) rather than just the paragraph tag. This may make the functionality more useful for other applications.
| } else { | ||
| // Some editing has happened to the span, so just remove it entirely. The user can put it back | ||
| // around just the href content if they need to prevent it from linking | ||
| while (spans[i].childNodes.length > 0) { |
There was a problem hiding this comment.
You can use Util.unwrap() for this I believe
This forward-from-the-start counting strategy was suggested by nmielnik as possibly being easier to read than the way it was working in the previous commits (counting backward). Also adds more tests to cover cases that were discovered while working on this strategy.
Auto link: suggestions from code review "possible-suggestions"
nmielnik
added a commit
that referenced
this pull request
Jun 12, 2015
Auto link: fix bug when entering link at end of paragraph
nysk
pushed a commit
to nysk/medium-editor
that referenced
this pull request
Aug 10, 2015
Auto link: fix bug when entering link at end of paragraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issue with auto-link: