-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: build.sh; WIP #24
Conversation
Hey, Thanks a lot! I myself tank into this issue on my intel mac. Can you see if the Asking cause gmake is just make on ubuntu and so this script might not work |
@@ -49,6 +49,7 @@ else | |||
fi | |||
|
|||
mkdir -p bindings | |||
mkdir -p bindings/whisper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the previous line, you can remove that
bf4f2f8
to
85ff736
Compare
|
I've tested on my Ubuntu machine - the |
rm -rf build-server | ||
mkdir build-server | ||
cd build-server | ||
cmake -DLLAMA_BUILD_SERVER=ON .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you will also need to take care of where CUDA flag was set or not. See the whisper command for reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you will also need to take care of where CUDA flag was set or not. See the whisper command for reference
CUDA flags? What do you mean?
This should make the
build.sh
script work. I've tested it on my local machine (i7 2020 MBP) and works. I will test it on my Ubuntu machine soon.Using
gmake
was the fix for macOS according to, ggerganov/llama.cpp#1570. I'm not sure if this will break for other platforms, in that case, we can add a simple detection depending on what platform the user is on.