Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: build.sh; WIP #24

Closed
wants to merge 3 commits into from

Conversation

rezaarezvan
Copy link

This should make the build.sh script work. I've tested it on my local machine (i7 2020 MBP) and works. I will test it on my Ubuntu machine soon.

Using gmake was the fix for macOS according to, ggerganov/llama.cpp#1570. I'm not sure if this will break for other platforms, in that case, we can add a simple detection depending on what platform the user is on.

@ghost
Copy link

ghost commented Jun 24, 2023

Hey, Thanks a lot!

I myself tank into this issue on my intel mac.

Can you see if the cmake commands work for you?

Asking cause gmake is just make on ubuntu and so this script might not work

@@ -49,6 +49,7 @@ else
fi

mkdir -p bindings
mkdir -p bindings/whisper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the previous line, you can remove that

@rezaarezvan
Copy link
Author

rezaarezvan commented Jun 25, 2023

Hey, Thanks a lot!

I myself tank into this issue on my intel mac.

Can you see if the cmake commands work for you?

Asking cause gmake is just make on ubuntu and so this script might not work

gmake will work on Ubuntu as well. The problem is specifically make on macOS, with gmake this works. So I think the gmake solution is fine. But I made the change so we use CMake now instead.

@rezaarezvan
Copy link
Author

Hey, Thanks a lot!
I myself tank into this issue on my intel mac.
Can you see if the cmake commands work for you?
Asking cause gmake is just make on ubuntu and so this script might not work

gmake will work on Ubuntu as well. The problem is specifically make on macOS, with gmake this works. So I think the gmake solution is fine. But I made the change so we use CMake now instead.

I've tested on my Ubuntu machine - the gmake solution works as well so it's up to either you (@cto-junior) or @yacineMTB to decide which approach we want to use :).

rm -rf build-server
mkdir build-server
cd build-server
cmake -DLLAMA_BUILD_SERVER=ON ..
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you will also need to take care of where CUDA flag was set or not. See the whisper command for reference

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you will also need to take care of where CUDA flag was set or not. See the whisper command for reference

CUDA flags? What do you mean?

@rezaarezvan rezaarezvan deleted the rezvan/build branch July 13, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant