Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftPM file to 5.0. #44

Merged
merged 1 commit into from Nov 8, 2019
Merged

Update SwiftPM file to 5.0. #44

merged 1 commit into from Nov 8, 2019

Conversation

phimage
Copy link
Contributor

@phimage phimage commented Nov 8, 2019

Fix compilation issue by adding import for UIBezierPath

This allow to open project in Xcode 11 by opening Package.swift
To have build and test available

Using command line, build could be checked by executing

sdk=`xcrun -sdk iphonesimulator -show-sdk-path`
sdkVersion=`echo $sdk | sed -E 's/.*iPhoneSimulator(.*)\.sdk/\1/'`
swift build  -Xswiftc "-sdk" -Xswiftc "$sdk" -Xswiftc "-target" -Xswiftc "x86_64-apple-ios$sdkVersion-simulator"

could be added to a CI like travis or github workflow like this

Fix compilation issue by adding import for `UIBezierPath`
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files           8        8           
  Lines         256      256           
=======================================
  Hits          242      242           
  Misses         14       14
Impacted Files Coverage Δ
Sources/Extensions/CAShapeLayer+Helpers.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48608d4...c2fafb0. Read the comment docs.

@yacir
Copy link
Owner

yacir commented Nov 8, 2019

@phimage Thx for your contribution.

@yacir yacir merged commit a26e4cc into yacir:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants