Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black editor theme #40

Closed
wants to merge 5 commits into from
Closed

Conversation

rgallagher27
Copy link
Contributor

I needed a way to easily alter the theme of the editor

yackle and others added 5 commits May 1, 2014 16:19
Signed-off-by: Ross Gallagher <ross_gallagher@rossgallagher.co.uk>

Conflicts:
	CLImageEditor/ViewController/_CLImageEditorViewController.m
	CLImageEditor/ViewController/_CLImageEditorViewController.xib
yackle added a commit that referenced this pull request May 6, 2014
@yackle
Copy link
Owner

yackle commented May 6, 2014

Thanks for great work!

Merged into develop branch.
I have modified a little. Please check it.

  • merged from your master branch instead of develop. because conflicts were not resolved correctly.
  • I think navigationbarstyle is better to set by UIAppearance for of the uniformity of other controls.

I think I'll merge into master if there is no problem, how about you?

@rgallagher27
Copy link
Contributor Author

Using UIAppearance is probably the better option, should be ok to merge into master.

yackle added a commit that referenced this pull request May 7, 2014
@yackle
Copy link
Owner

yackle commented May 7, 2014

merged. thanks!

@yackle yackle closed this May 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants