Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve plotting to make better use of y range #42

Merged
merged 25 commits into from Aug 26, 2016
Merged

improve plotting to make better use of y range #42

merged 25 commits into from Aug 26, 2016

Conversation

otteresk
Copy link
Contributor

@otteresk otteresk commented Feb 1, 2016

New calculation of y range to better handle big values with small variations (e.g. no. documents)

@otteresk
Copy link
Contributor Author

Just wondering if you have questions or comments on this one.

@Orbiter
Copy link
Member

Orbiter commented Feb 10, 2016

Hi otteresk, sorry for the delay I have been very busy recently. I will look through your changes as soon as possible.

@otteresk
Copy link
Contributor Author

@otteresk otteresk closed this Mar 19, 2016
@otteresk otteresk reopened this Mar 19, 2016
@otteresk
Copy link
Contributor Author

Hi Orbiter et al.
may I propose to at least integrate the changes to PerformanceMemory_p.java and ChartPlotter.java - as those are (simple) bug fixes.
Regards, Andreas

@reger24
Copy link
Member

reger24 commented May 2, 2016

Hi,
small note fyi,
the patched Y-scaling has a small side effect on chart with only few data points (min, max equal)
with patch
networkhistory-withpatch

without patch
networkhistory-withoutpatch

@@ -168,7 +168,7 @@ private void drawVerticalScale(final boolean left, final int scale, final int pi
}
setColor(colorNaming);
line(x - 3, y, x + 3, y, 100);
s1 = (s >= 1000000 && s % 10000 == 0) ? Integer.toString(s / 1000000) + "M" : (s >= 1000 && s % 1000 == 0) ? Integer.toString(s / 1000) + "K" : Integer.toString(s);
s1 = (s >= 1000000 && s % 1000000 == 0) ? Integer.toString(s / 1000000) + "M" : (s >= 1000 && s % 1000 == 0) ? Integer.toString(s / 1000) + "K" : Integer.toString(s);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: this bugfix will be applied for sure

@otteresk
Copy link
Contributor Author

otteresk commented May 2, 2016

Thanks for the test and feedback, Burkhard.
I will look into this and come back.

reger24 pushed a commit that referenced this pull request May 3, 2016
@otteresk
Copy link
Contributor Author

otteresk commented May 3, 2016

Should be fixed now.

@otteresk
Copy link
Contributor Author

otteresk commented May 9, 2016

I really have to get used to git(hub) :-)
Now NetworkHistory.java should be able to handle all kind of cases.
Thanks for testing and sorry for any inconveniences.

@otteresk
Copy link
Contributor Author

otteresk commented Jun 6, 2016

Hi Burkhard, any chance you find time for another test?

@reger24
Copy link
Member

reger24 commented Jun 7, 2016

Hi @otteresk, I believe the mentioned issue you've resolved.
but I still would like to leave it up to @Orbiter to accept or reject you pull request.

@Orbiter Orbiter merged commit e5955ac into yacy:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants