Fixed HTTPS mixed content warnings and errors #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactored the related code : - extracted it in a method - catch Exception and log it, rather than Throwable which is bad practice
Handle eventual images loading errors.
Also disabled currently not working URLs.
https://github.com/luccioman/yacy_search_server.git into mixedcontent Conflicts: source/net/yacy/yacy.java
We now use the same protocol as the one used to display the config page : so when using https, the content is not blocked by the browser detecting mixed-content.
luccioman
referenced
this pull request
Aug 17, 2016
!!! attention !!! to make sure YaCy can start, https will be disabled if port 8443 is used - added ping test for above to migration - as of now port for https is hardcoded to default 8443 - if not urgend required I'd leave it this way (it's standard) to use different ports for http and https - post https port on ConfigBasic.html (if active)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue described in mantis 680 (http://mantis.tokeek.de/view.php?id=680). Browsers warn and even block some contents when using HTTPS with the YaCy web interface.
Fix applied as described in mantis additional information.
Test configuration :