Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pydot2 to be forward-setuptools-friendly #105

Open
tiborsimko opened this issue Oct 8, 2021 · 2 comments
Open

upgrade pydot2 to be forward-setuptools-friendly #105

tiborsimko opened this issue Oct 8, 2021 · 2 comments

Comments

@tiborsimko
Copy link

Current behaviour

Yadage depends on pydot2 for visualisation:

$ rg -C 3 pydot2 setup.py 
49-        "viz": [
50-            # manually adding extras of adage[extra] because of pip
51-            # issue https://github.com/pypa/pip/issues/3189
52:            "pydot2",
53-            "pygraphviz",
54-            "pydotplus",
55-        ],

The last release of pydot2 happened in January 2014.

With the new versions of setuptools, this leads to installation problems. Here is a small demonstrator:

$ mkvirtualenv test -p python3.8
$ pip install --upgrade pip setuptools
$ cd src/yadage
$ pip install '.[viz]'
...
   Complete output (1 lines):
    error in pydot2 setup command: use_2to3 is invalid.

Workaround

Do not update setuptools, then things will work.

Expected behaviour

It would be really great to make yadage dependent on latest-greatest dot-handling packages, instead of relying on the too old pydot2 package. For example, upgrade to pydot, which is being actively maintained.

Notes

Ditto for other viz dependencies, e.g. pydotplus was last released in December 2014. (But it works with latest setuptools.)

tiborsimko added a commit to tiborsimko/reana-workflow-engine-yadage that referenced this issue Oct 8, 2021
Because of yadage visualisation dependencies, notably pydot2, we need
to temporarily pin setuptools version. See yadage/yadage#105.
tiborsimko added a commit to tiborsimko/reana-workflow-engine-yadage that referenced this issue Oct 8, 2021
Because of yadage visualisation dependencies, notably pydot2, we need
to temporarily pin setuptools version. See yadage/yadage#105.
tiborsimko added a commit to tiborsimko/reana-workflow-engine-yadage that referenced this issue Oct 8, 2021
Because of yadage visualisation dependencies, notably pydot2, we need
to temporarily pin setuptools version. See yadage/yadage#105.
tiborsimko added a commit to tiborsimko/reana-workflow-engine-yadage that referenced this issue Oct 8, 2021
Because of yadage visualisation dependencies, notably pydot2, we need
to temporarily pin setuptools version. See yadage/yadage#105.
tiborsimko added a commit to tiborsimko/reana-workflow-engine-yadage that referenced this issue Oct 11, 2021
Because of yadage visualisation dependencies, notably pydot2, we need
to temporarily pin setuptools version. See yadage/yadage#105.
tiborsimko added a commit to tiborsimko/reana-workflow-engine-yadage that referenced this issue Oct 11, 2021
Because of yadage visualisation dependencies, notably pydot2, we need
to temporarily pin setuptools version. See yadage/yadage#105.
@lukasheinrich
Copy link
Collaborator

I think @matthewfeickert found the same thing

@matthewfeickert
Copy link
Member

I think @matthewfeickert found the same thing

Yup. For examples of where I had to move from pydot2 to pydot c.f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants