fix: Return functionality of yadage.utils.coerce_data_arg to state_provider_from_string
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
commented
Feb 8, 2022
yadage/steering_object.py
Outdated
Comment on lines
49
to
56
| metadir = ( | ||
| kwargs["metadir"] | ||
| if "metadir" in kwargs.keys() and kwargs["metadir"] is not None | ||
| else f"{kwargs['dataarg']}/_yadage/" | ||
| ) | ||
| if dataopts.get("overwrite") and os.path.exists(metadir): | ||
| shutil.rmtree(metadir) | ||
|
|
There was a problem hiding this comment.
This part is currently problematic. With this in it is currently failing
pytest -sx tests/test_utilcli.py
but if I remove it then using this yadage code with
recast run testing/busyboxtest --backend local --tag hello
fails.
matthewfeickert
force-pushed
the
fix/get-working
branch
2 times, most recently
from
9b96bbb
to
67f04d7
Compare
matthewfeickert
force-pushed
the
fix/get-working
branch
from
67f04d7
to
ee2deb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116
PR #92 moved and generalized functionality from
yadage/state_providers/__init__.pytoyadage/utils.pywith the introduction ofyadage.utils.coerce_data_arg. However, it never added that functionality back intoyadage/state_providers/__init__.py$ git show b03a637f2afa53f5967472e5df7d17b229905e0a -- yadage/state_providers/ commit b03a637f2afa53f5967472e5df7d17b229905e0a Author: Lukas <lukas.heinrich@gmail.com> Date: Fri Nov 15 03:20:25 2019 +0100 coerce dataarg (#92) * coerce data arg diff --git a/yadage/state_providers/__init__.py b/yadage/state_providers/__init__.py index ea0840a..a2c65bd 100644 --- a/yadage/state_providers/__init__.py +++ b/yadage/state_providers/__init__.py @@ -80,8 +80,6 @@ def fromenv_provider(dataarg, dataopts): def state_provider_from_string(dataarg, dataopts=None): dataopts = dataopts or {} - if len(dataarg.split(":", 1)) == 1: - dataarg = "local:" + dataarg for k in providersetup_handlers.keys(): if dataarg.startswith(k): return providersetup_handlers[k](dataarg, dataopts) (venv) feickert@ThinkPad-X1:~/Code/GitHub/yadage/yadage$ git show b03a637f2afa53f5967472e5df7d17b229905e0a -- yadage/utils.py commit b03a637f2afa53f5967472e5df7d17b229905e0a Author: Lukas <lukas.heinrich@gmail.com> Date: Fri Nov 15 03:20:25 2019 +0100 coerce dataarg (#92) * coerce data arg diff --git a/yadage/utils.py b/yadage/utils.py index 1859174..9c00c48 100644 --- a/yadage/utils.py +++ b/yadage/utils.py @@ -247,3 +247,9 @@ def pointerize(data, asref=False, stepid=None): ) return data.asrefs(callback=callback) + + +def coerce_data_arg(dataarg): + if len(dataarg.split(":", 1)) == 1: + dataarg = "local:" + dataarg + return dataargThis PR adds that functionality back and simplifies some additional logic.
Squash and merge commit message