Skip to content
This repository has been archived by the owner on Dec 23, 2022. It is now read-only.

Improve url handler for non-https links #147

Closed
yafp opened this issue Nov 5, 2019 · 0 comments
Closed

Improve url handler for non-https links #147

yafp opened this issue Nov 5, 2019 · 0 comments
Assignees
@yafp
Labels
enhancement New feature or request
Milestone
1.8.0

Comments

@yafp
Copy link
Owner

yafp commented Nov 5, 2019

The url handler for services opens any http:// or https:// links if the user clicks it - using shell.openExternal(event.url);

Security wise it would make sense to display a confirm dialog before opening a non-https:// link.
@yafp yafp added the enhancement New feature or request label Nov 5, 2019
@yafp yafp added this to the 1.8.0 milestone Nov 5, 2019
@yafp yafp self-assigned this Nov 5, 2019
yafp added a commit that referenced this issue Nov 5, 2019
@yafp
20191105 - Improving url handler, see #147. Several other minor changes.
ab96260
@yafp yafp closed this as completed Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yafp yafp

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
1 participant
@yafp