Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 3 - jacob, Lina #24

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Step 3 - jacob, Lina #24

merged 3 commits into from
Nov 13, 2020

Conversation

KyungminLeeDev
Copy link

URL 유효성 검사를 정규표현식으로 구현했습니다.

@KyungminLeeDev KyungminLeeDev changed the title Step 2 - jacob, Lina Step 3 - jacob, Lina Nov 12, 2020
Copy link
Contributor

@yagom yagom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다!
정규표현식으로 http나 https만 확인하면 URL을 검증할 수 있을까요?
좀 더 부수적인 조건은 필요 없을까요?
더 다른 조건이 생각나지 않으면 다음 스텝으로 넘어가도 좋습니다.
더 수정하지 않으려면 머지요청 주세요!

@lina0322
Copy link

@yagom 뒤에 스텝에서 URL 검증 부분을 개선 해보겠습니다. 머지 부탁드립니다!

@yagom yagom merged commit 5c6c355 into yagom-academy:1-jacob Nov 13, 2020
@KyungminLeeDev KyungminLeeDev deleted the step-3 branch November 13, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants