docs: update api.md for setWebHook (fix #1083) #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Thanks for the PR! I'd like to suggest to clarify in the doc that the user needs to verify the X-Telegram-Bot-Api-Secret-Token manually because there's currently no such verification logic implemented in node-telegram-bot-api. Or maybe we can implement a verification logic inside the library so that the user won't need to bother with getting and checking headers for every webhook request. |
kamikazechaser
approved these changes
May 11, 2023
There was a problem hiding this comment.
LGTM
You can also add some simple check here https://github.com/yagop/node-telegram-bot-api/blob/master/examples/webhook/express.js to show how to use it (along with any inline documentation).
|
secret-bot-token what? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run docDescription
Add missing
setWebhooksecret_tokenparameter to the documentationReferences
setWebhooksecret_tokenparameter to the documentation #1083