src/polling: Fix the Offset Infinite Loop bug #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
GochoMugo
force-pushed
the
fix/offset-infinite-loop
branch
from
a210b47
to
b883259
Compare
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 81.3% 89.42% +8.11%
==========================================
Files 5 5
Lines 1717 1314 -403
Branches 360 265 -95
==========================================
- Hits 1396 1175 -221
+ Misses 321 139 -182
Continue to review full report at Codecov.
|
|
While this bug fix may not able to be shipped in the next release, I would highly appreciate if I got some feedback on the implementation. /cc @yagop @kamikazechaser @GingerPlusPlus @phillipadsmith |
References: * Issue #36: #36 * answer/solution: #36 (comment)
GochoMugo
force-pushed
the
fix/offset-infinite-loop
branch
from
946f179
to
e94f41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: