Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add topic config and delete topic #38

Merged
merged 3 commits into from Mar 26, 2015
Merged

Add topic config and delete topic #38

merged 3 commits into from Mar 26, 2015

Conversation

patelh
Copy link
Collaborator

@patelh patelh commented Mar 19, 2015

Changes:

  • Contains commit from Update to Kafka 0.8.2.0 #31
  • Add topic config to create topic
  • Add topic config to topic view
  • Add delete topic to topic view for versions 0.8.2+
  • Increment version to 1.1
  • Increase API timeout to 5 seconds

@yahoocla
Copy link

CLA is valid!

This was referenced Mar 19, 2015
Closed
Closed
Open
patelh
patelh reviewed Mar 21, 2015
View reviewed changes
app/controllers/Topic.scala
Future.successful(Ok(views.html.topic.createTopic(clusterName, createTopicForm)))
createTopicForm(clusterName).map { errorOrForm =>
errorOrForm.fold(
error => Ok(views.html.errors.onApiError(error)),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need better error rendering here, this just prints error without any nav.

patelh added a commit that referenced this pull request Mar 26, 2015
@patelh
Merge pull request #38 from patelh/topic-config
5c6eb4c 
Add topic config and delete topic
@patelh patelh merged commit 5c6eb4c into yahoo:master Mar 26, 2015
@patelh patelh deleted the topic-config branch March 26, 2015 05:54
@patelh patelh mentioned this pull request Mar 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patelh @yahoocla @ggrossetie