Support kafka 0.10.x.x #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
@fuji-151a Nice work. Mind agreeing to the terms pointed out above so this PR can be merged? |
|
@bigdata4u Thank, you!! |
|
@yahoocla could you merge this PR |
|
@fuji-151a please add tests for in ClusterConfig serialization/deserialization |
|
@fuji-151a have you tested it with version 0.10.2.1? |
|
Thanks for the review @patelh !!
Yes, I have tested it with kafka version 0.10.2.1. |
|
lgtm |
|
Thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added feature that was be able to select version 0.10.1.1, 0.10.2.0 and 0.10.2.1 from UI.
Tests are passing and the instance I'm running locally seems to be working properly.
And He is saying too. (See: #394)
Please check this pull request.
Thank you.