Merge pull request #45 from VerizonAdPlatforms/OMSDK-2152/parsing-of-…

…max-ad-search-time Added max ad search time parsing
yahoo · Jan 30, 2019 · 1729155 · 1729155
2 parents 79648d1 + 42af52a
commit 1729155
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 1 deletion.
diff --git a/PlayerCore b/PlayerCore
diff --git a/sources/VVPSDK.swift b/sources/VVPSDK.swift
@@ -237,6 +237,7 @@ public struct VVPSDK {
             softTimeout: videoResponse.adSettings.softTimeout,
             hardTimeout: videoResponse.adSettings.hardTimeout,
             startTimeout: videoResponse.adSettings.startTimeout,
+            maxSearchTime: videoResponse.adSettings.maxSearchTime,
             maxDuration: videoResponse.adSettings.maxDuration,
             maxVASTWrapperRedirectCount: videoResponse.adSettings.maxVASTWrapperRedirectCount)
 

diff --git a/sources/player/observer/ObserverTests.swift b/sources/player/observer/ObserverTests.swift
@@ -23,6 +23,7 @@ class ObserverTests: XCTestCase {
                                                     softTimeout: 2.5,
                                                     hardTimeout: 3.5,
                                                     startTimeout: 4,
+                                                    maxSearchTime: 9,
                                                     maxDuration: 90,
                                                     maxVASTWrapperRedirectCount: 3),
                                   vpaidSettings: .init(document: testUrl),

diff --git a/sources/video provider/VideoProviderResponse.swift b/sources/video provider/VideoProviderResponse.swift
@@ -43,6 +43,7 @@ extension VideoProvider.Response {
         public let softTimeout: Double
         public let hardTimeout: Double
         public let startTimeout: Double
+        public let maxSearchTime: Double
         public let maxDuration: Int
         public let maxVASTWrapperRedirectCount: Int
     }

diff --git a/sources/video provider/provider/VideoProviderParsing.swift b/sources/video provider/provider/VideoProviderParsing.swift
@@ -60,6 +60,7 @@ extension VideoProvider.Parse {
                          softTimeout: json.parse("softTimeout"),
                          hardTimeout: json.parse("hardTimeout"),
                          startTimeout: json.parse("startTimeout"),
+                         maxSearchTime: json.parse("maxSearchTime"),
                          maxDuration: json.parse("maxShowTime"),
                          maxVASTWrapperRedirectCount: json.parse("maxVASTWrapperRedirectCount"))
     }

diff --git a/sources/video provider/provider/VideoProviderTests.swift b/sources/video provider/provider/VideoProviderTests.swift
@@ -351,6 +351,7 @@ class VideoProviderTests: XCTestCase {
         "softTimeout" : 0.5,
         "hardTimeout" : 2.5,
         "startTimeout": 3.5,
+        "maxSearchTime" : 9.0,
         "maxShowTime": 90,
         "maxVASTWrapperRedirectCount": 3,
     ]
@@ -386,6 +387,7 @@ class VideoProviderTests: XCTestCase {
         expect(value.adSettings.startTimeout) == 3.5
         expect(value.adSettings.maxDuration) == 90
         expect(value.adSettings.maxVASTWrapperRedirectCount) == 3
+        expect(value.adSettings.maxSearchTime) == 9.0
 
         expect(try parse(VideoProviderTests.emptyResponse, .native)).to(throwError())
     }